Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable system prompt override #323

Conversation

TamiTakamiya
Copy link
Contributor

Description

System Prompt Override added with #227 is no longer working. System prompt was set using the
_system_prompt attribute of QueryHelper class. However, the DocsSummarizer class, which extends
QueryHelper, now has system_prompt attribute, which does not contain the logic required for
System Prompt Override. We can simply use the _system_prompt attribute as it is set in the constructor
of QueryHelper.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.
    Ansible Lightspeed chatbot has the UI to override system prompt and it can be used for verification.

@TamiTakamiya TamiTakamiya force-pushed the TamiTakamiya/reenable-system-prompt-override branch from 1b89146 to 11b8201 Compare January 27, 2025 22:01
@TamiTakamiya TamiTakamiya force-pushed the TamiTakamiya/reenable-system-prompt-override branch from 11b8201 to d0ea6b9 Compare January 27, 2025 22:20
@TamiTakamiya TamiTakamiya marked this pull request as ready for review January 28, 2025 00:43
@tisnik tisnik merged commit 895ebe5 into road-core:main Jan 28, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants