Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed docstyle #16

Merged
merged 1 commit into from
Oct 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ols/src/llms/providers/azure_openai.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ class AzureOpenAI(LLMProvider):

@property
def default_params(self) -> dict[str, Any]:
"""Default LLM params."""
"""Construct and return structure with default LLM params."""
self.url = str(self.provider_config.url or self.url)
self.credentials = self.provider_config.credentials
deployment_name = self.provider_config.deployment_name
Expand Down
2 changes: 1 addition & 1 deletion ols/src/llms/providers/bam.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class BAM(LLMProvider):

@property
def default_params(self) -> dict[str, Any]:
"""Default LLM params."""
"""Construct and return structure with default LLM params."""
return {
"decoding_method": "sample",
"max_new_tokens": 512,
Expand Down
2 changes: 1 addition & 1 deletion ols/src/llms/providers/fake_provider.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class FakeProvider(LLMProvider):

@property
def default_params(self) -> dict[str, Any]:
"""Default LLM params."""
"""Construct and return structure with default LLM params."""
return {}

def load(self) -> LLM:
Expand Down
2 changes: 1 addition & 1 deletion ols/src/llms/providers/openai.py
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class OpenAI(LLMProvider):

@property
def default_params(self) -> dict[str, Any]:
"""Default LLM params."""
"""Construct and return structure with default LLM params."""
self.url = str(self.provider_config.url or self.url)
self.credentials = self.provider_config.credentials
# provider-specific configuration has precendence over regular configuration
Expand Down
2 changes: 1 addition & 1 deletion ols/src/llms/providers/rhelai_vllm.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class RHELAIVLLM(LLMProvider):

@property
def default_params(self) -> dict[str, Any]:
"""Default LLM params."""
"""Construct and return structure with default LLM params."""
self.url = str(self.provider_config.url or self.url)
self.credentials = self.provider_config.credentials
# provider-specific configuration has precendence over regular configuration
Expand Down
2 changes: 1 addition & 1 deletion ols/src/llms/providers/rhoai_vllm.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ class RHOAIVLLM(LLMProvider):

@property
def default_params(self) -> dict[str, Any]:
"""Default LLM params."""
"""Construct and return structure with default LLM params."""
self.url = str(self.provider_config.url or self.url)
self.credentials = self.provider_config.credentials
# provider-specific configuration has precendence over regular configuration
Expand Down
2 changes: 1 addition & 1 deletion ols/src/llms/providers/watsonx.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ class Watsonx(LLMProvider):

@property
def default_params(self) -> dict[str, Any]:
"""Default LLM params."""
"""Construct and return structure with default LLM params."""
# https://www.ibm.com/docs/en/watsonx-as-a-service?topic=models-parameters
return {
GenParams.DECODING_METHOD: "sample",
Expand Down
6 changes: 3 additions & 3 deletions scripts/evaluation/utils/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class OpenAIVanilla(OpenAI):

@property
def default_params(self):
"""Default LLM params."""
"""Construct and return structure with default LLM params."""
self.url = str(self.provider_config.url)
self.credentials = self.provider_config.credentials
# provider-specific configuration has precendence over regular configuration
Expand All @@ -34,7 +34,7 @@ class AzureOpenAIVanilla(AzureOpenAI):

@property
def default_params(self):
"""Default LLM params."""
"""Construct and return structure with default LLM params."""
self.url = str(self.provider_config.url or self.url)
self.credentials = self.provider_config.credentials
deployment_name = self.provider_config.deployment_name
Expand Down Expand Up @@ -71,7 +71,7 @@ class WatsonxVanilla(Watsonx):

@property
def default_params(self):
"""Default LLM params."""
"""Construct and return structure with default LLM params."""
return {
GenTextParamsMetaNames.MAX_NEW_TOKENS: 1024,
}
Expand Down
Loading