Merge pull request #292 from tisnik/enable-w0622

Enable Pylinter rule W0622 on CI

ols/src/cache/redis_cache.py

@@ -8,9 +8,11 @@
 from redis.backoff import ExponentialBackoff
 from redis.exceptions import (
     BusyLoadingError,
-    ConnectionError,  # noqa: A004
     RedisError,
 )
+from redis.exceptions import (
+    ConnectionError as RedisConnectionError,
+)
 from redis.retry import Retry
 
 from ols.app.models.config import RedisConfig
@@ -52,7 +54,7 @@ def initialize_redis(self, config: RedisConfig) -> None:
 
         retry_on_error: Optional[list[type[RedisError]]] = None
         if config.retry_on_error:
-            retry_on_error = [BusyLoadingError, ConnectionError]
+            retry_on_error = [BusyLoadingError, RedisConnectionError]
 
         # initialize Redis client
         # pylint: disable=W0201

pyproject.toml

@@ -163,4 +163,4 @@ packages = ["ols"]
 
 [tool.pylint."MESSAGES CONTROL"]
 good-names = ["e"]
-disable = ["C0103", "C0301", "C0302", "E0602", "E0611", "E1101", "R0902", "R0903", "R0913", "R0914", "W0102", "W0212", "W0511", "W0613", "W0621", "W0622", "W0707", "W0718", "W0719", "R0801", "R0917"]
+disable = ["C0103", "C0301", "C0302", "E0602", "E0611", "E1101", "R0902", "R0903", "R0913", "R0914", "W0102", "W0212", "W0511", "W0613", "W0621", "W0707", "W0718", "W0719", "R0801", "R0917"]

tests/e2e/utils/cluster.py

@@ -9,7 +9,7 @@
 
 
 def run_oc(
-    args: list[str], input=None, ignore_existing_resource=False  # noqa: A002
+    args: list[str], command=None, ignore_existing_resource=False
 ) -> subprocess.CompletedProcess:
     """Run a command in the OpenShift cluster."""
     try:
@@ -18,7 +18,7 @@ def run_oc(
             capture_output=True,
             text=True,
             check=True,
-            input=input,
+            input=command,
         )
         return res
     except subprocess.CalledProcessError as e:

tests/e2e/utils/ols_installer.py

@@ -66,7 +66,7 @@ def update_ols_config() -> None:
     updated_configmap = yaml.dump(configmap)
 
     cluster_utils.run_oc(["delete", "configmap", "olsconfig"])
-    cluster_utils.run_oc(["apply", "-f", "-"], input=updated_configmap)
+    cluster_utils.run_oc(["apply", "-f", "-"], command=updated_configmap)
 
 
 def replace_ols_image(ols_image: str) -> None:

tests/mock_classes/mock_llm_chain.py

@@ -27,7 +27,9 @@ def __init__(self, *args, **kwargs):
         def __call__(self, *args, **kwargs):
             return retval
 
-        def invoke(self, input, config=None, **kwargs):  # noqa: A002
+        def invoke(
+            self, input, config=None, **kwargs  # noqa: A002 pylint: disable=W0622
+        ):
             """Perform invocation of the LLM chain."""
             if retval is not None:
                 return retval