Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rnp work on OpenBSD (WIP) #477

Closed
wants to merge 6 commits into from
Closed

Conversation

ronaldtse
Copy link
Contributor

@ronaldtse ronaldtse commented Sep 30, 2017

This is WIP, there are a few issues in the build scripts:

TAR

tar ... --strip 1 in ci/install.sh does not work on OpenBSD

GnuPG

Compilation of libassuan gives this error.

libtool: compile:  clang -DHAVE_CONFIG_H -I. -I.. -I.. -I/local-builds/builds/gpg21-install/include -g -O2 -Wall -Wcast-align -Wshadow -Wstrict-prototypes -Wpointer-arith -MT libassuan_la-assuan-socket.lo -MD -MP -MF .deps/libassuan_la-assuan-socket.Tpo -c assuan-socket.c  -fPIC -DPIC -o .libs/libassuan_la-assuan-socket.o
assuan-socket.c:806:30: error: use of undeclared identifier 'EPROTO'
          gpg_err_set_errno (EPROTO);
                             ^
assuan-socket.c:840:18: warning: cast from 'struct sockaddr *' to 'struct sockaddr_in6 *' increases required alignment from 1 to 4 [-Wcast-align]
      addr_in6 = (struct sockaddr_in6 *)addr;
                 ^~~~~~~~~~~~~~~~~~~~~~~~~~~
assuan-socket.c:849:17: warning: cast from 'struct sockaddr *' to 'struct sockaddr_in *' increases required alignment from 1 to 4 [-Wcast-align]
      addr_in = (struct sockaddr_in *)addr;
                ^~~~~~~~~~~~~~~~~~~~~~~~~~
assuan-socket.c:866:26: error: use of undeclared identifier 'EPROTO'
      gpg_err_set_errno (EPROTO);
                         ^
assuan-socket.c:927:39: warning: cast from 'struct sockaddr *' to 'struct sockaddr_in6 *' increases required alignment from 1 to 4 [-Wcast-align]
      struct sockaddr_in6 *addr_in6 = (struct sockaddr_in6 *)addr;
                                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
assuan-socket.c:942:37: warning: cast from 'struct sockaddr *' to 'struct sockaddr_in *' increases required alignment from 1 to 4 [-Wcast-align]
      struct sockaddr_in *addr_in = (struct sockaddr_in *)addr;
                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~
4 warnings and 2 errors generated.
*** Error 1 in target 'libassuan_la-assuan-socket.lo'
mv -f .deps/libassuan_la-assuan-logging.Tpo .deps/libassuan_la-assuan-logging.Plo
*** Error 1 in src (Makefile:842 'libassuan_la-assuan-socket.lo')
*** Error 2 in src (Makefile:1039 'install')
*** Error 1 in /local-builds/gpg21/libassuan-2.4.3 (Makefile:468 'install-recursive')

In fact, OpenBSD (and macOS brew) comes with GnuPG 2.1 and we probably don't need to re-compile things?

@dewyatt could we skip the build of GnuPG if the system's version is already 2.1+?

@ronaldtse
Copy link
Contributor Author

Looks like EPROTO could be replaced with EIO on *BSD:
http://hg.rename-it.nl/dovecot-2.1-pigeonhole/rev/ef5045159e6b

@codecov
Copy link

codecov bot commented Sep 30, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@19caf29). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #477   +/-   ##
=========================================
  Coverage          ?   63.09%           
=========================================
  Files             ?       61           
  Lines             ?    18074           
  Branches          ?      171           
=========================================
  Hits              ?    11404           
  Misses            ?     6617           
  Partials          ?       53

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19caf29...6cb3696. Read the comment docs.

@ronaldtse
Copy link
Contributor Author

Anyone interested in OpenBSD support?

@ronaldtse
Copy link
Contributor Author

@erikbor is working on this one. Thanks!

@ronaldtse ronaldtse force-pushed the ronaldtse-build-openbsd branch from ee8be89 to 6cb3696 Compare January 23, 2018 02:58
@ronaldtse
Copy link
Contributor Author

Superseded by #590.

@ronaldtse ronaldtse closed this Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants