Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for armor and cleartext messages parsing #423

Merged
merged 7 commits into from
Aug 24, 2017

Conversation

ni4
Copy link
Contributor

@ni4 ni4 commented Aug 24, 2017

Sorry for putting a bit different things into the single pull request.
So this one:

  • fixes misc armoring/dearmoring processing problems
  • fixes partial data length processing in dearmoring code
  • fixed cleartext signing/verification
  • adds CLI tests for armored and cleartext stuff

@codecov
Copy link

codecov bot commented Aug 24, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@5bcf8b7). Click here to learn what that means.
The diff coverage is 72.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #423   +/-   ##
=========================================
  Coverage          ?   52.27%           
=========================================
  Files             ?       49           
  Lines             ?    13101           
  Branches          ?      162           
=========================================
  Hits              ?     6849           
  Misses            ?     6202           
  Partials          ?       50
Impacted Files Coverage Δ
src/lib/writer.c 48.27% <60%> (ø)
src/librepgp/reader.c 66.81% <76.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bcf8b7...4f38848. Read the comment docs.

Copy link
Contributor

@ronaldtse ronaldtse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements!

@ronaldtse
Copy link
Contributor

@ni4 I feel that the characters like "- " and '\n' should be assigned by some definition.

@catap
Copy link
Contributor

catap commented Aug 24, 2017

Looks good but I agree with @ronaldtse remarks about "- ".

@ni4
Copy link
Contributor Author

ni4 commented Aug 24, 2017

@ronaldtse @catap Thanks, you are right. Will update PR with defines

@ni4
Copy link
Contributor Author

ni4 commented Aug 24, 2017

@ronaldtse @catap Done. If somebody have idea of better place for those defines (so we can use them from repgp/reader.c) you are welcome to share.
Otherwise feel free to merge it

@ronaldtse
Copy link
Contributor

LGTM, yet one of the CLI tests are failing due to GnuPG problem... can it be fixed?

@ronaldtse ronaldtse merged commit 895d604 into master Aug 24, 2017
@ronaldtse ronaldtse deleted the ni4-383-fix-armored-messages-parsing branch August 24, 2017 22:07
@ni4
Copy link
Contributor Author

ni4 commented Aug 25, 2017

@ronaldtse Sorry, only now found your message. Sure, I remember about this issue and will fix in one of the subsequent PRs with CLI tests update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants