-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for armor and cleartext messages parsing #423
Conversation
…ts; Updated CLI tests with armored signed/encrypted messages
…nd trailing spaces.
Codecov Report
@@ Coverage Diff @@
## master #423 +/- ##
=========================================
Coverage ? 52.27%
=========================================
Files ? 49
Lines ? 13101
Branches ? 162
=========================================
Hits ? 6849
Misses ? 6202
Partials ? 50
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the improvements!
@ni4 I feel that the characters like |
Looks good but I agree with @ronaldtse remarks about |
@ronaldtse @catap Thanks, you are right. Will update PR with defines |
@ronaldtse @catap Done. If somebody have idea of better place for those defines (so we can use them from repgp/reader.c) you are welcome to share. |
LGTM, yet one of the CLI tests are failing due to GnuPG problem... can it be fixed? |
@ronaldtse Sorry, only now found your message. Sure, I remember about this issue and will fix in one of the subsequent PRs with CLI tests update. |
Sorry for putting a bit different things into the single pull request.
So this one: