Changed pgp_add_time to use enum instead of char* parameter.

[ni4]

Fixes #219 , mostly for better code readability.

[codecov-io]

Codecov Report

Merging #233 into master will decrease coverage by <.01%.
The diff coverage is 55.55%.

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
- Coverage   44.22%   44.22%   -0.01%     
==========================================
  Files          32       32              
  Lines        9089     9092       +3     
  Branches       16       16              
==========================================
+ Hits         4020     4021       +1     
- Misses       5064     5066       +2     
  Partials        5        5

Impacted Files	Coverage Δ
src/lib/packet-key.c	76.66% <100%> (+0.15%)	⬆️
src/lib/signature.c	38.96% <46.66%> (-0.19%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8673a5d...9100708. Read the comment docs.

[kriskwiatkowski]

LGTM

[kriskwiatkowski]

Small step in right direction

[ni4]

What policy do we have? May I merge it now, or wait for @dewyatt approval as well?

[dewyatt]

@ronaldtse Do you want to formalize a PR review process (see @ni4 comment above)? For example, require 2 approvals on each PR, or something like that (you can enforce a policy via github too, of course).

[ni4]

Thanks! Yeah, possibly it would be easier/more organized to have some simple formal rules, like naming of the branches, number of approves needed for the merge and so on.

[ronaldtse]

Yes @dewyatt let's formalize a policy to require two approvals to merge, and the other typical rules we should follow, could you help add them to the Dev Guide?