Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make rnp_signature_handle_st C++ object #2279

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Make rnp_signature_handle_st C++ object #2279

merged 1 commit into from
Nov 28, 2024

Conversation

desvxx
Copy link
Contributor

@desvxx desvxx commented Sep 30, 2024

fixes #2271

@desvxx desvxx force-pushed the desvxx-2271-refactor-rnp_signature_handle_st branch from 8a1f7db to 5a32290 Compare September 30, 2024 00:39
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 30, 2024
View reviewed changes
src/lib/rnp.cpp Fixed Show fixed Hide fixed
src/lib/rnp.cpp Fixed Show fixed Hide fixed
@codecov Codecov
Copy link

codecov bot commented Sep 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.77%. Comparing base (ac2c2dd) to head (615de52).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/lib/rnp.cpp 84.61% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2279      +/-   ##
==========================================
- Coverage   84.81%   84.77%   -0.05%     
==========================================
  Files         116      115       -1     
  Lines       23292    23036     -256     
==========================================
- Hits        19755    19528     -227     
+ Misses       3537     3508      -29

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@desvxx desvxx force-pushed the desvxx-2271-refactor-rnp_signature_handle_st branch 2 times, most recently from a49829b to fa417d9 Compare November 19, 2024 23:37
maxirmx
maxirmx requested changes Nov 26, 2024
View reviewed changes
Copy link
Member

@maxirmx maxirmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please help rebase on brew-bundle-fix to fix MacOS 14 build

@desvxx desvxx force-pushed the desvxx-2271-refactor-rnp_signature_handle_st branch from fa417d9 to 615de52 Compare November 26, 2024 20:08
@maxirmx maxirmx self-requested a review November 26, 2024 21:00
maxirmx
maxirmx approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@maxirmx maxirmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ni4
ni4 approved these changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@ni4 ni4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ni4 ni4 merged commit 24895aa into rnpgp:main Nov 28, 2024
124 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ni4 ni4 ni4 approved these changes

@maxirmx maxirmx maxirmx approved these changes

@ronaldtse ronaldtse Awaiting requested review from ronaldtse

@antonsviridenko antonsviridenko Awaiting requested review from antonsviridenko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make rnp_signature_handle_st C++ object instead of using calloc.
3 participants
@desvxx @maxirmx @ni4