Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update windows-native runner to windows-2022 #2259

Merged
merged 2 commits into from
Aug 22, 2024
Merged

Conversation

ni4
Copy link
Contributor

@ni4 ni4 commented Aug 4, 2024

Due to update from Botan 3.3.0 to 3.5.0 windows-2019 runner started causing problems (microsoft/vcpkg#40276).
So it's time to update to windows-2022, another point is that windows-2025 would become available soon.

Copy link

codecov bot commented Aug 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.58%. Comparing base (e3662a7) to head (c609398).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2259   +/-   ##
=======================================
  Coverage   83.58%   83.58%           
=======================================
  Files         107      107           
  Lines       23163    23163           
=======================================
+ Hits        19360    19361    +1     
+ Misses       3803     3802    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ni4 ni4 force-pushed the ni4-debug-vcpkg-botan-issue branch 3 times, most recently from 876d050 to 53a1833 Compare August 7, 2024 10:08
@ni4 ni4 force-pushed the ni4-debug-vcpkg-botan-issue branch 7 times, most recently from b44f8ab to 216fd43 Compare August 21, 2024 13:36
@ni4 ni4 force-pushed the ni4-debug-vcpkg-botan-issue branch from 216fd43 to c609398 Compare August 22, 2024 08:14
@ni4 ni4 marked this pull request as ready for review August 22, 2024 09:05
@ni4 ni4 changed the title Debug Botan vcpkg installation failure. Update windows-native runner to windows-2022 Aug 22, 2024
@ni4 ni4 requested review from maxirmx, ronaldtse and desvxx August 22, 2024 09:07
Copy link
Member

@maxirmx maxirmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxirmx maxirmx merged commit 0048f4d into main Aug 22, 2024
115 checks passed
@maxirmx maxirmx deleted the ni4-debug-vcpkg-botan-issue branch August 22, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants