Support for designated revokers #2160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2160 +/- ##
==========================================
+ Coverage 77.06% 77.25% +0.18%
==========================================
Files 194 194
Lines 37262 37748 +486
==========================================
+ Hits 28717 29163 +446
- Misses 8545 8585 +40 ☔ View full report in Codecov by Sentry. |
ni4
changed the title
ni4
force-pushed
the
ni4-1785-designated-revokers-support-new
branch
2 times, most recently
from
b03d927 to
b17e096
Compare
ni4
force-pushed
the
ni4-1785-designated-revokers-support-new
branch
from
b17e096 to
599bf2c
Compare
ni4
force-pushed
the
ni4-1785-designated-revokers-support-new
branch
4 times, most recently
from
6d5a30f to
d3bb13c
Compare
…ginning of a list.
…/rnp_key_signature_sign.
…nature_set_hash() and rnp_key_signature_set_revocation_reason().
ni4
force-pushed
the
ni4-1785-designated-revokers-support-new
branch
from
d3bb13c to
3c958aa
Compare
ronaldtse
approved these changes
Jan 23, 2024
|
Thanks guys! Having two approvals so merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add support for designated revoker/revocation key, partially adding support for custom key signature creation.
Fixes #1785