Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed FindBotan.cmake to match recent vcpkg update #2138

Merged
merged 2 commits into from
Oct 28, 2023

Conversation

maxirmx
Copy link
Member

@maxirmx maxirmx commented Oct 27, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3dcfb12) 76.83% compared to head (79391b7) 76.88%.

❗ Current head 79391b7 differs from pull request most recent head 2b945cc. Consider uploading reports for the commit 2b945cc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2138      +/-   ##
==========================================
+ Coverage   76.83%   76.88%   +0.04%     
==========================================
  Files         193      193              
  Lines       36968    36982      +14     
==========================================
+ Hits        28406    28432      +26     
+ Misses       8562     8550      -12     

see 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxirmx maxirmx force-pushed the maxirmx-windows-findbotan-fix branch from 97d5920 to cf2df1d Compare October 27, 2023 14:11
src/tests/cli_tests.py Fixed Show fixed Hide fixed
src/tests/cli_tests.py Fixed Show fixed Hide fixed
@maxirmx maxirmx force-pushed the maxirmx-windows-findbotan-fix branch from 3717432 to 2b945cc Compare October 27, 2023 17:50
@maxirmx maxirmx marked this pull request as ready for review October 27, 2023 20:07
@ronaldtse ronaldtse merged commit 65356e1 into main Oct 28, 2023
110 checks passed
@ronaldtse ronaldtse deleted the maxirmx-windows-findbotan-fix branch October 28, 2023 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants