Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Clang builds to Ubuntu, CentOS7, CentOS8 (+ ossl), MacOS, Debian9 and Windows-msys2 workflows #1684

Merged
merged 29 commits into from
Nov 10, 2021
Merged

Added Clang builds to Ubuntu, CentOS7, CentOS8 (+ ossl), MacOS, Debian9 and Windows-msys2 workflows #1684

merged 29 commits into from
Nov 10, 2021

Conversation

maxirmx
Copy link
Member

@maxirmx maxirmx commented Nov 9, 2021 •
edited
Loading

Clang build and test for the following workflows:

  • centos7
  • centos8-ossl
  • centos8
  • debian9
  • macos
  • ubuntu
  • windows (msys)

Fixed:

Changes previously reviewd but not included in this PR:

  • Fix to 'centos8 / pkgconfig-cmake-target' job which was disabled in the upstream version. I have a fix for it, if you need it pls. create separate issue. It may go to another PR if so.
  • All convinience changes that helped to run/debug CI scripts outside GHA environment

@maxirmx maxirmx marked this pull request as ready for review November 9, 2021 21:46
This was linked to issues Nov 9, 2021
ci: Build with clang-cl #1129
Closed
clang/libgcrypt v1.9.3 issue (CentOS 8 workflow) #1668
Closed
clang/GnuPG v2.3.0-beta983 issue (CentOS 8 workflow) #1669
Closed
clang/rnp build issue (CentOS 7 workflow) #1670
Closed
@ronaldtse
Copy link
Contributor

ronaldtse commented Nov 10, 2021 •
edited
Loading

@maxirmx can you rebase this PR to remove merges and conflicts, and clean up the history before merging (i.e. combine the multiple commits with an identical message)? Thanks.

@ronaldtse
Copy link
Contributor

ronaldtse commented Nov 10, 2021 •
edited
Loading

Changes previously reviewd but not included in this PR:

  • Fix to 'centos8 / pkgconfig-cmake-target' job which was disabled in the upstream version. I have a fix for it, if you need it pls. create separate issue. It may go to another PR if so.
  • All convinience changes that helped to run/debug CI scripts outside GHA environment

Yes let's create separate issues for these.

This was referenced Nov 10, 2021
Closed
Closed
@ronaldtse ronaldtse changed the base branch from master to maxirmx-1129-build-with-clang-cl November 10, 2021 01:50
@ronaldtse
Copy link
Contributor

Actually easier to squash this in order to remove the cruft.

ni4 and others added 14 commits November 10, 2021 14:49
@ni4 @ronaldtse
Update CI exported symbols check.
c3eac17
@ni4 @ronaldtse
Use std::string instead of fixed-size PATH_MAX buffer in pgp_dest_fil…
715d8bc 
…e_param_t.
@ni4 @ronaldtse
Use std::string instead of PATH_MAX buffer when asking for filename i…
c2194eb 
…n CLI.
@ni4 @ronaldtse
Remove PATH_MAX dependency from the tests.
28b6d87
@ni4 @ronaldtse
Deallocate handle instead of calling Hash::finish() in the destructor.
441ecc1
@maxirmx @ronaldtse
CC, CXX env variables
64ec9d3
@maxirmx @ronaldtse
Update build matrix
3e83fc3
@maxirmx @ronaldtse
Clang build and test for the following workflows:
0894540 
- centos7
- centos8-ossl
- centos8
- debian9
- macos
- ubuntu

Fixes:
- fixes #1670
- fixes #1669
- fixes #1668
- Packaging tests for centos8 (gcc and clang)
@maxirmx @ronaldtse
Remove empty lines
9dd07bd
@maxirmx @ronaldtse
Added clang to msys workflow
e4b9d36 
* Added clang to msys workflow
* Removed empty lines
* Commented out test we think we do not need
@maxirmx @ronaldtse
Add clang build\test to Msys workflow
c960f16 
* Added clang build\test to Msys workflow
* Fixed ci scripts issues reported by lint
@maxirmx @ronaldtse
Removed extra whitespaces
04e43d8
@maxirmx @ni4 @ronaldtse
Fix few CI shellcheck errors
22990e1 
Co-authored-by: Nickolay Olshevsky <[email protected]>
@maxirmx @ronaldtse
Cleanup clang builds
601c815
maxirmx and others added 14 commits November 10, 2021 14:58
@maxirmx @ronaldtse
Added clang to ubuntu build
a7b44fa
@maxirmx @ronaldtse
Added clang to centos7 build
c027419
@maxirmx @ronaldtse
Added clang to centos8 open ssl build, cosmetic improvements to ubunt…
fefb02c 
…u and cento7
@maxirmx @ronaldtse
Cosmetic improvements to windows-msvc and centos8-ossl workflows
ff5b0ca
@maxirmx @ronaldtse
Added clang to centos8 workflow
f88211e
@maxirmx @ronaldtse
Added clang to macos workflow
0dd35fe
@maxirmx @ronaldtse
Added clang to debian workflow
7e594d7
@maxirmx @ronaldtse
Added clang to windows-msys2 workflow
55445e1
@maxirmx @ronaldtse
Extended fetch depth to 10 for debian workflow
26979bc
@maxirmx @ronaldtse
Ensure that GnuPG is built with with gcc, even if we are testing clang (
b779f89 
#1669)
@maxirmx @ronaldtse
Added clang setup to debian install function
af7c577
@maxirmx @ronaldtse
Added software-properties-common to debian dependencies
3a78ad7
@maxirmx @ronaldtse
Added clang/msys environment setup
3275fab
@ronaldtse
Merge branch 'maxirmx-1129-build-with-clang-cl' into maxirmx-1129-bui…
2c9e728 
…ld-with-clang-cl
@ronaldtse ronaldtse changed the base branch from maxirmx-1129-build-with-clang-cl to maxirmx-build-with-clang-cl November 10, 2021 07:04
@ronaldtse ronaldtse changed the base branch from maxirmx-build-with-clang-cl to maxirmx-1129-build-with-clang-cl November 10, 2021 07:06
@ronaldtse ronaldtse changed the base branch from maxirmx-1129-build-with-clang-cl to maxirmx-build-with-clang-cl November 10, 2021 07:08
@ronaldtse
Copy link
Contributor

Just going to squash this and apply the same patches in a new PR.

@ronaldtse ronaldtse merged commit b28340c into rnpgp:maxirmx-build-with-clang-cl Nov 10, 2021
@ronaldtse ronaldtse mentioned this pull request Nov 10, 2021
Merged
@maxirmx
Copy link
Member Author

maxirmx commented Nov 10, 2021

Actually easier to squash this in order to remove the cruft.

Please squash it on merge. I specially wrote a comment for this PR that can be used for squashed commit.
I am happy to adhere to any rules but it really hurts to uncover new and new ones when I deploy a PR that takes ~300 CI job runs to polish and verify

@ronaldtse
Copy link
Contributor

@maxirmx I've already cleaned up the commits and re-applied them to the new master in #1688, there should be nothing further to do for this now.

@maxirmx maxirmx deleted the maxirmx-1129-build-with-clang-cl branch November 11, 2021 14:34
@ni4 ni4 added this to the v0.16.0 milestone Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ribose-jeffreylau ribose-jeffreylau Awaiting requested review from ribose-jeffreylau

@ni4 ni4 Awaiting requested review from ni4

@ronaldtse ronaldtse Awaiting requested review from ronaldtse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.16.0
3 participants
@maxirmx @ronaldtse @ni4