Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used maximum password request tries. #1112

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joke325
Copy link
Contributor

@joke325 joke325 commented Apr 28, 2020

Closes #913

@codecov
Copy link

codecov bot commented Apr 28, 2020

Codecov Report

Merging #1112 into master will decrease coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1112      +/-   ##
==========================================
- Coverage   83.41%   83.40%   -0.02%     
==========================================
  Files          76       76              
  Lines       29720    29724       +4     
==========================================
  Hits        24792    24792              
- Misses       4928     4932       +4     
Impacted Files Coverage Δ
src/rnp/fficli.cpp 71.89% <0.00%> (-0.22%) ⬇️
src/rnp/rnpcfg.cpp 67.87% <100.00%> (+0.40%) ⬆️
src/librepgp/stream-write.cpp 78.93% <0.00%> (-0.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56d9ae9...ccbfe01. Read the comment docs.

@ronaldtse
Copy link
Contributor

ronaldtse commented May 5, 2020

The windows workflow here is broken despite how many times I "retry", it can't checkout the ref... Can someone do a manual rebase?

@dewyatt dewyatt force-pushed the joke325-issue913 branch from 2d22270 to ccbfe01 Compare May 5, 2020 18:19
@dewyatt
Copy link
Contributor

dewyatt commented May 5, 2020

This is a good start but I think it's incomplete.

  • Personally I'd prefer an argument name like password-attempts vs num-tries.
  • I'm thinking rnpkeys should also accept and utilize this argument.
  • I don't think rnp actually utilizes this, does it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit password tries according to CLI/default parameters.
3 participants