Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix images and React styles in generated windows #113

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

mecirt
Copy link

@mecirt mecirt commented Apr 5, 2022

  • Fix links in new window by setting the base URL correctly
  • Update styles in the new window whenever they change in the parent.
    This is needed if the application mounts new React components inside
    the new window (React updates those styles on-demand instead of
    loading them at start).

mecirt added 3 commits April 5, 2022 15:12
* Update styles in the new window whenever they change in the parent.
  This is needed if the application mounts new React components inside
  the new window (React updates those styles on-demand instead of
  loading them at start).
@rmariuzzo rmariuzzo self-assigned this Nov 28, 2022
@rmariuzzo rmariuzzo self-requested a review November 28, 2022 06:03
@rmariuzzo rmariuzzo removed their assignment Nov 28, 2022
@bluSCALE4
Copy link

Why was the help wanted tag added? Do you want someone to verify this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants