Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update on RoCur FAQ page: remove image specs #162

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

sndaba
Copy link
Contributor

@sndaba sndaba commented Jan 10, 2025

Hi @shannonpileggi thank you for approving and merging all our pull requests.
@reikookamoto I noticed the image specs are appearing and had to remove them. I thought it would be ok after the merge but they were still showing. If you can add the specs without them showing, that would be cool
Otherwise, merge ready.

@sndaba sndaba requested a review from a team as a code owner January 10, 2025 14:20
@sndaba sndaba requested a review from SoyAndrea January 10, 2025 14:20
Copy link

Welcome sndaba! It looks like this is your first contribution to this repository. 🎉

Please remember to add yourself to the .zenodo.json.

@reikookamoto
Copy link
Contributor

@rladies/website How should we adjust image size? Can I can use raw HTML in the Markdown doc instead?

@drmowinckels
Copy link
Member

you can use raw html if you want, but my question is if you need to resize the images? Some of them have small text and letting them be large might help people read it.
If you do opt for resizing, I recommend using max-width rather than width, because that will still allow responsiveness.

@reikookamoto
Copy link
Contributor

@drmowinckels When I was previewing it locally, I thought some of the pics were overwhelmingly taking up the page. But good point about legibility, let's just leave it as is and not play around with the image width👍

@sndaba
Copy link
Contributor Author

sndaba commented Jan 11, 2025

@shannonpileggi merge ready.

@shannonpileggi shannonpileggi merged commit 3bdfeff into main Jan 13, 2025
5 checks passed
@shannonpileggi shannonpileggi deleted the sndaba-patch-1 branch January 13, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants