Update on RoCur FAQ page #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome sndaba! It looks like this is your first contribution to this repository. 🎉 Please remember to add yourself to the .zenodo.json. |
|
@Simisani, I haven't reviewed this PR yet. Could you please hold on until
I've got a chance to go over it? Thanks!
…On Tue, Jan 7, 2025, 02:47 simisani ndaba ***@***.***> wrote:
@shannonpileggi <https://github.com/shannonpileggi> merge ready
—
Reply to this email directly, view it on GitHub
<#161 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANBG5ZVZDTZNRKGDKQ6OKTD2JOA7TAVCNFSM6AAAAABUTUJONOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNZUGU4DSNJQHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@reikookamoto sure, ok. |
reikookamoto
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Hi @sndaba, thanks for your patience while I reviewed this file. My changes are:
-
Removing screenshots for Twitter -
Saving local copies of screenshots for Bluesky, and replacing URLs with file paths, to make the directory more self-contained -
Playing with image widths so the screenshots don't take up too much space -
Making the alt text slightly more descriptive -
Fixing minor typos
The HTML previews renders without issue on my computer. Please tag Shannon once it's ready for merging.
|
@reikookamoto Thanks for making the changes. We will see how it looks. |
shannonpileggi
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@reikookamoto Changes made for Bluesky instructions.
Please add more FAQs that may be relevant.