Merge pull request ocaml#5712 from rjbou/partially-installed

switch: more precise message for fatal error on switch creation
rjbou · Dec 12, 2023 · 173e833 · 173e833
2 parents a1cdd7c + 73b6b15
commit 173e833
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/master_changes.md b/master_changes.md
@@ -28,6 +28,7 @@ users)
 ## Remove
 
 ## Switch
+  * Precise message for Ctrl-c-ed opam switch creation "Switch left partially installed" [#5713 @rjbou - fix #5710]
 
 ## Config
 

diff --git a/src/client/opamSwitchCommand.ml b/src/client/opamSwitchCommand.ml
@@ -339,7 +339,11 @@ let create
     let () =
       try OpamStd.Exn.fatal e with e ->
         OpamStd.Exn.finalise e @@ fun () ->
-        OpamConsole.warning "Switch %s left partially installed"
+        OpamConsole.error
+          "Switch %s left %s installed.\n\
+           To clean it, use 'opam switch remove %s'"
+          (OpamConsole.colorise `underline (OpamSwitch.to_string st.switch))
+          (OpamConsole.colorise `bold "partially")
           (OpamSwitch.to_string st.switch)
     in
     OpamStd.Exn.finalise e @@ fun () ->