-
-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RzSearch refactor #4762
Draft
Rot127
wants to merge
108
commits into
rizinorg:dev
Choose a base branch
from
Rot127:rz-search
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
RzSearch refactor #4762
+13,147
−1,085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0c558c2
to
b59292d
Compare
5 tasks
String length and buffer size are disconnected in future search. The buffer sizes are not controllable by the user.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Your checklist for this pull request
Detailed description
Companion PR: rizinorg/rizin-testbins#162
What happens here:
Slowly copying changes from https://github.com/Rot127/rizin/tree/rz-search-reference (which is #4742 with some comments already addressed).
Will resend to
fuzz-dist
when all the tests pass here.Stuff to do (without any order)
search IO
API which doesn't require knowledge of search spaces (whatrz_search_run()
was before).search.align
shoudl default tosearch.alignment=asm.cpu_bits/8
.ctrl + c
RzSearchHit
to hold more complex data.find()
callback.Test plan
...
Closing issues
closes #1586