Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Prettier 3 #10

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Upgrade to Prettier 3 #10

merged 1 commit into from
Jan 31, 2024

Conversation

pauldraper
Copy link
Collaborator

@pauldraper pauldraper commented Jan 8, 2024

Prettier did a significant refactor for version 3 (e.g. async APIs).

Breaking change for better_rules_javascript: This removes the plugins argument of configure_prettier(). Instead, the dependencies need to be on the js_library() for the prettier config (which lists the plugins, so this is a natural fit).

Added tests.

@pauldraper pauldraper force-pushed the pauldraper/prettier branch from f24c49c to 9dd9702 Compare January 8, 2024 04:51
Copy link

@nathanmoon nathanmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok to my untrained eye ;)

@pauldraper pauldraper merged commit 0696c8d into main Jan 31, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants