Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace AttPlist with PlistInterface in AnnotScore inheritance #3923

Merged
merged 5 commits into from
Jan 29, 2025
Merged

Replace AttPlist with PlistInterface in AnnotScore inheritance #3923

merged 5 commits into from
Jan 29, 2025

Conversation

DILewis
Copy link
Contributor

@DILewis DILewis commented Jan 29, 2025

No description provided.

lpugin
lpugin requested changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@lpugin lpugin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also need to adjust:

  • The constructor
  • AnnotScore::Reset
  • Reading and writing AnnotScore

lpugin
lpugin reviewed Jan 29, 2025
View reviewed changes
src/iomei.cpp Outdated Show resolved Hide resolved
lpugin
lpugin reviewed Jan 29, 2025
View reviewed changes
src/annotscore.cpp Outdated Show resolved Hide resolved
lpugin
lpugin reviewed Jan 29, 2025
View reviewed changes
src/iomei.cpp Outdated Show resolved Hide resolved
@lpugin lpugin merged commit b3f2fca into rism-digital:develop-annote Jan 29, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpugin lpugin lpugin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DILewis @lpugin