Xxchan/compile #20098
Draft
Xxchan/compile #20098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
xxchan
commented
Jan 10, 2025
Comment on lines
-28
to
+36
| pub struct ConnectorSourceWorker<P: SourceProperties> { | ||
| pub struct ConnectorSourceWorker { | ||
| source_id: SourceId, | ||
| source_name: String, | ||
| current_splits: SharedSplitMapRef, | ||
| enumerator: P::SplitEnumerator, | ||
| // XXX: box or arc? | ||
| enumerator: Box<dyn SplitEnumerator>, | ||
| period: Duration, | ||
| metrics: Arc<MetaMetrics>, | ||
| connector_properties: P, | ||
| connector_properties: ConnectorProperties, |
There was a problem hiding this comment.
one core upper layer change here
Signed-off-by: xxchan <[email protected]>
xxchan
force-pushed
the
xxchan/compile
branch
from
0ea38c8 to
3fb5aa4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
may help #16841
Checklist
Documentation
Release note