Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(secret): use aws-lc-rs to replace aes-gcm crate #20091

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yuhao-su
Copy link
Contributor

@yuhao-su yuhao-su commented Jan 9, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

aws-lc-rs has completed FIPS validation. We will add an option to enable FIPS compliance in a separate PR.

The aws-lc-rs version is set to 1.6 to align with our rustls version 0.23.5. Also only aws-lc-rs<1.12.0 has passed the FIPS validation.

I locally tested that encryption/decryption results from both aws-lc-rs and aes-gcm are identical.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@yuhao-su yuhao-su requested a review from a team as a code owner January 9, 2025 20:01
@yuhao-su yuhao-su added ci/run-backwards-compat-tests Run backwards compatibility tests in your PR. and removed type/refactor labels Jan 9, 2025
@zwang28
Copy link
Contributor

zwang28 commented Jan 10, 2025

FYI I've CryptoProvider::install_default globally.

@yuhao-su
Copy link
Contributor Author

FYI I've CryptoProvider::install_default globally.

Got it. This PR only uses aws-lc-rs in non fips mode. Not sure if can cause the same problem as the rustls

Copy link
Contributor

@tabVersion tabVersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The impl LGTM

This PR only uses aws-lc-rs in non fips mode.

Where do we control the FIPS mode?

Also only aws-lc-rs<1.12.0 has passed the FIPS validation.

Can you also share some docs about the FIPS validated versions?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/run-backwards-compat-tests Run backwards compatibility tests in your PR. type/refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants