disable predicate batch_iceberg_predicate_pushdown #20058
Draft
+87
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
8 tasks
kwannoel
added
ci/main-cron/run-selected
ci/run-e2e-iceberg-sink-v2-tests
labels
Graphite App
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Comment on lines
40
to
+41
| fn apply(&self, plan: PlanRef) -> Option<PlanRef> { | ||
| let filter: &BatchFilter = plan.as_batch_filter()?; | ||
| let input = filter.input(); | ||
| let scan: &BatchIcebergScan = input.as_batch_iceberg_scan()?; | ||
| // NOTE(kwannoel): We only fill iceberg predicate here. | ||
| assert_eq!(scan.predicate, IcebergPredicate::AlwaysTrue); | ||
|
|
||
| let predicate = filter.predicate().clone(); | ||
| let (iceberg_predicate, rw_predicate) = | ||
| rw_predicate_to_iceberg_predicate(predicate, scan.schema().fields()); | ||
| let scan = scan.clone_with_predicate(iceberg_predicate); | ||
| if rw_predicate.always_true() { | ||
| Some(scan.into()) | ||
| } else { | ||
| let filter = filter | ||
| .clone_with_input(scan.into()) | ||
| .clone_with_predicate(rw_predicate); | ||
| Some(filter.into()) | ||
| } | ||
| Some(plan) |
There was a problem hiding this comment.
The original code had an assertion that scan.predicate must be AlwaysTrue. By changing this function to simply return Some(plan), that assertion could be violated. Consider either removing the assertion if it's no longer needed, or adding validation to ensure scan.predicate remains AlwaysTrue when bypassing the transformation logic.
Spotted by Graphite Reviewer
Is this helpful? React 👍 or 👎 to let us know.
kwannoel
force-pushed
the
01-07-disable_predicate_batch_iceberg_predicate_pushdown
branch
from
ebf92f1 to
c85f07e
Compare
kwannoel
force-pushed
the
kwannoel/iceberg-predicate-pushdown-perf
branch
from
08f770b to
7b260c9
Compare
Base automatically changed from
kwannoel/iceberg-predicate-pushdown-perf
to
main
January 8, 2025 06:13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
Documentation
Release note