Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(telemtry): remove redundant report_event during recovery #20032

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

fuyufjh
Copy link
Member

@fuyufjh fuyufjh commented Jan 6, 2025

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Our telemetry reports too many events. One of the cause is that some code path calls report_event() not only at the time something is created, but also on recovery, which is not expected.

Checklist

  • I have written necessary rustdoc comments.
  • I have added necessary unit tests and integration tests.
  • I have added test labels as necessary.
  • I have added fuzzing tests or opened an issue to track them.
  • My PR contains breaking changes.
  • My PR changes performance-critical code, so I will run (micro) benchmarks and present the results.
  • My PR contains critical fixes that are necessary to be merged into the latest release.

Documentation

  • My PR needs documentation updates.
Release note

@github-actions github-actions bot added the type/fix Bug fix label Jan 6, 2025
Comment on lines +54 to +58
// REMOVE ME: To find out all report_event calls
println!(
"report_event_common backtrace:\n{}",
std::backtrace::Backtrace::force_capture()
);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This debug code with println! and backtrace capture appears to be temporary development scaffolding. While it's helpful for debugging telemetry calls during development, it should be removed before merging to prevent performance overhead and log spam in production. Consider using tracing or debug logging if this visibility needs to be preserved in a more controlled way.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants