-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: upgrade to openssl@3 #13746
build: upgrade to openssl@3 #13746
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
I'm trying these, but no luck for now:
|
This reverts commit efebb49.
This comment was marked as off-topic.
This comment was marked as off-topic.
pre-built binary success!!! https://buildkite.com/risingwavelabs/docker/builds/14759#018c216c-1f88-48ea-8f14-addc9e7fcafb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13746 +/- ##
==========================================
+ Coverage 68.19% 68.24% +0.05%
==========================================
Files 1524 1524
Lines 262232 262250 +18
==========================================
+ Hits 178829 178984 +155
+ Misses 83403 83266 -137
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
# Ubuntu 18.04: 2.27 (Already EOL 2023-05-31) | ||
# Ubuntu 20.04: 2.31 | ||
# | ||
# manylinux2014: CentOS 7 (EOL 2024-06-30), GLIBC 2.17 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just adding a link for future (in 7 months) reference:
https://github.com/pypa/manylinux
The goal of the manylinux project is to provide a convenient way to distribute binary Python extensions as wheels on Linux. This effort has produced PEP 513 (manylinux1), PEP 571 (manylinux2010), PEP 599 (manylinux2014) and PEP 600 (manylinux_x_y).
PEP 599 defines the following platform tags:
manylinux2014_x86_64
- ...
Wheels are built on CentOS 7 which will reach End of Life (EOL) on June 30th, 2024.
PEP 600 has been designed to be "future-proof" and does not enforce specific symbols and a specific distro to build. It only states that a wheel tagged
manylinux_x_y
shall work on any distro based onglibc>=x.y
. The manylinux project supports:
manylinux_2_24
images forx86_64
,i686
,aarch64
,ppc64le
ands390x
.manylinux_2_28
images forx86_64
,aarch64
,ppc64le
ands390x
.manylinux_2_28 (AlmaLinux 8 based)
manylinux_2_24 (Debian 9 based) - EOL
Support for
manylinux_2_24
has ended on January 1st, 2023.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very unfortunately 2_24 is already EOL. When 2014 (2_17) is EOL, we won’t have a nice alternative immediately. 🤡
2_28 is larger than Amazon Linux. And... Amazon Linux‘s EOL is sooooo long
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
And fix the compilation & linking error in the nightly pre-built binary enviroment.
Q: Does the upgrade contain behavior changes?
TBO I'm not sure.
According to the migration guide, the changes should be very occasional.
AFAIK for us,
openssl
is only used bypgwire
andrdkafka
. I did some very basic manual test:pgwire
: We only support very basic SSL: feat: introduce basic ssl connection #5775... And it's not brokenrdkafa
: manually tested withSCRAM-SHA-256
+SASL_SSL
. It works.Anyway, since openssl 1.1 is already EOL in September, we have to upgrade it sooner or later.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.