Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sparta Assert for Target Pipe without Execution Unit #151

Merged
merged 2 commits into from
Feb 12, 2024

Conversation

aarongchan
Copy link
Collaborator

@aarongchan aarongchan commented Feb 8, 2024

Forgot to add an assert to check that there is a dispatcher (thus a subsequent issue queue/execution unit) that can handle a target pipe of an instruction. If one forgets to define one, i.e you forget to define an execution unit to handle DIV target pipe, the simulator will end early, but no error will be thrown.

@aarongchan aarongchan added the bug Something isn't working label Feb 8, 2024
@aarongchan aarongchan requested a review from klingaard February 8, 2024 00:02
@aarongchan aarongchan self-assigned this Feb 8, 2024
core/Dispatch.cpp Outdated Show resolved Hide resolved
@klingaard klingaard merged commit 71e636b into riscv-software-src:master Feb 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants