Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Custom logo UI support #6521

Merged
merged 14 commits into from
Feb 3, 2025
Merged

feat: Custom logo UI support #6521

merged 14 commits into from
Feb 3, 2025

Conversation

AdityaHegde
Copy link
Collaborator

@AdityaHegde AdityaHegde commented Jan 29, 2025

  • Show logo in nav bar when it is set for the org. (Moved to feat: Show custom logo in UI #6530)
  • Add a logo editing setting component
  • Support uploading logo from UI. (Need to figure out the CORS issue while uploading)
  • Support removing the log from UI.

Sorry, something went wrong.

@AdityaHegde AdityaHegde mentioned this pull request Jan 30, 2025
5 tasks
@ericokuma
Copy link
Contributor

Some UXQA feedback:

  1. Instead of
    image
    Can we have a preview of the image I uploaded? Here's how Notion does it:
Screenshot 2025-01-30 at 8 55 55 AM

The one on the left is light mode, right is dark mode. Because we don't have dark mode for now, we can just show the light mode preview

  1. When I first click on the logo edit icon, the modal appears below
Screenshot 2025-01-30 at 8 57 10 AM

After I upload an image, it jumps above
Screenshot 2025-01-30 at 8 57 56 AM

  1. Scaling. I'm not sure if the logo upload is scaling properly. I uploaded a .png file and the new logo is much smaller than the default Rill logo
Screenshot 2025-01-30 at 8 59 07 AM

vs

Screenshot 2025-01-30 at 8 59 20 AM

@mindspank
Copy link
Contributor

  1. Resolved via fix: padding and remove hover bg #6544

@AdityaHegde AdityaHegde force-pushed the feat/file-upload-input branch from c980acc to 4d3ea0f Compare February 3, 2025 05:53
@AdityaHegde AdityaHegde marked this pull request as ready for review February 3, 2025 07:58
@AdityaHegde AdityaHegde added the blocker A release blocker issue that should be resolved before a new release label Feb 3, 2025
Base automatically changed from feat/file-upload-input to main February 3, 2025 13:26
@AdityaHegde AdityaHegde merged commit 35407c5 into main Feb 3, 2025
7 checks passed
@AdityaHegde AdityaHegde deleted the feat/custom-logo-upload branch February 3, 2025 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker A release blocker issue that should be resolved before a new release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants