Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rill time issues around truncate and arithmatic #6509

Merged
merged 4 commits into from
Jan 30, 2025
Merged

fix: rill time issues around truncate and arithmatic #6509

merged 4 commits into from
Jan 30, 2025

Conversation

AdityaHegde
Copy link
Collaborator

@AdityaHegde AdityaHegde commented Jan 27, 2025 •
edited
Loading

  1. Fix truncate when arithmetic is involved. For example a value like 0W, 0W+1d was being incorrectly truncated by week for both start and end.
  2. Support @ now, @ latest @ 2024-02-09 modifiers to apply the full time range for now/latest/abs time. EG: Support 0W, 0W+1D @ now, should return beginning of week to a day after beginning of week relative to now.
  3. Support case insensitive grains for day, week, quarter and year.
  4. Fix timeutil.Truncate when firstMonth is invalid.

@AdityaHegde AdityaHegde marked this pull request as ready for review January 28, 2025 02:53
begelundmuller
begelundmuller approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@begelundmuller begelundmuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AdityaHegde AdityaHegde merged commit 4821496 into main Jan 30, 2025
7 checks passed
@AdityaHegde AdityaHegde deleted the fix/rill-time-followups branch January 30, 2025 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@begelundmuller begelundmuller begelundmuller approved these changes

@briangregoryholmes briangregoryholmes Awaiting requested review from briangregoryholmes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AdityaHegde @begelundmuller