-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split web tests #3706
split web tests #3706
Conversation
fixes #3443 |
It looks like |
Thanks for the review @ericpgreen2. I removed all those extra run conditions -- I was being super timid and conservative in not taking them out :-) I think the prettier job may pick up a handful of things that fall outside of the web code quality checks. If it's ok with you, I'd rather deal with that separately rather than rolling that audit of prettier coverage into this PR. @himadrisingh -- please take a look at this and let us know if we're missing anything. If it looks ok, please go ahead and merge. Thank you! |
Splits web tests up into:
Note that we have a separate GH action that runs prettier on the entire repo (prettier.yaml) so I thought it was redundant to have the prettier checks for each web folder. Easy to add back in if that is incorrect.
Looking to @himadrisingh for approval from the dev-ops perspective since I'm not super familiar with the ins-and-outs of GH actions. In particular, I don't know what the "dorny/paths-filter@v2" does, so I just copied that over as-is across the board. Please LMK if that need to be changed or can be simplified
But also fyi @ericpgreen2 @djbarnwal @AdityaHegde @briangregoryholmes to have extra eyes on this.
Partially addresses #3443, though we may want to look into parallelizing (or otherwise speeding up) the e2e at some point.