Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split web tests #3706

Merged
merged 3 commits into from
Dec 19, 2023
Merged

split web tests #3706

merged 3 commits into from
Dec 19, 2023

Conversation

bcolloran
Copy link
Contributor

@bcolloran bcolloran commented Dec 14, 2023

Splits web tests up into:

  • code quality (lint and type check)
  • unit tests (we apparently only have unit tests in web-common and web-auth, though we have not been running the auth tests in CI, so those are added)
  • e2e tests (only web-local and web-admin have this, though web-admin only seems to have a test stub for now)

Note that we have a separate GH action that runs prettier on the entire repo (prettier.yaml) so I thought it was redundant to have the prettier checks for each web folder. Easy to add back in if that is incorrect.

Looking to @himadrisingh for approval from the dev-ops perspective since I'm not super familiar with the ins-and-outs of GH actions. In particular, I don't know what the "dorny/paths-filter@v2" does, so I just copied that over as-is across the board. Please LMK if that need to be changed or can be simplified

But also fyi @ericpgreen2 @djbarnwal @AdityaHegde @briangregoryholmes to have extra eyes on this.

Partially addresses #3443, though we may want to look into parallelizing (or otherwise speeding up) the e2e at some point.

@bcolloran bcolloran self-assigned this Dec 14, 2023
@bcolloran
Copy link
Contributor Author

fixes #3443

@ericpgreen2
Copy link
Contributor

It looks like .prettierignore lists pretty much all files/directories that aren't in our web workspaces. I'd be in favor of moving the standalone prettier check into the web code quality workflow.

@bcolloran
Copy link
Contributor Author

bcolloran commented Dec 15, 2023

Thanks for the review @ericpgreen2. I removed all those extra run conditions -- I was being super timid and conservative in not taking them out :-)

I think the prettier job may pick up a handful of things that fall outside of the web code quality checks. If it's ok with you, I'd rather deal with that separately rather than rolling that audit of prettier coverage into this PR.

@himadrisingh -- please take a look at this and let us know if we're missing anything. If it looks ok, please go ahead and merge. Thank you!

@bcolloran bcolloran merged commit 9c673f0 into main Dec 19, 2023
4 checks passed
@bcolloran bcolloran deleted the split-web-tests branch December 19, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants