-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error telemetry in cloud #3516
Error telemetry in cloud #3516
Conversation
4fba9c2
to
7455526
Compare
Can you add handling for client-side errors at runtime? I think something like this: window.onerror = (msg, url, line, col, error) => {
// capture error & emit telemetry
// show a full error page
};
window.onunhandledrejection = (event) => {
// capture error & emit telemetry
// show a full error page
}; |
Can you add details in the PR description about where the telemetry gets sent? |
This is looking good! I haven't QA'd it though. Can add a screenshot of the various telemetry in action in the downstream viz tool? Rill Cloud or Rill Legacy? It'd be very cool if this telemetry were included as a dashboard in the |
$: if ($page.params.project && $user.data?.user?.id) { | ||
metricsService.loadCloudFields({ | ||
isDev: window.location.host.startsWith("localhost"), | ||
projectId: $page.params.project, | ||
userId: $user.data?.user?.id, | ||
}); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- What about tracking the
organizationId
too? - Can we load the
userId
from theAvatarButton.svelte
component? Because the userID will be present if the user is logged in on the Home and Org pages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added organizationId
. It might be better to load all the data at a single place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment on metricsService.loadCloudFields()
, and there's still a leftover console log, else looks good!
Looking forward to seeing the Rill dashboard!
Checklist
Summary
Issue addressed:
We do not have any feedback from cloud UI.
Details:
As a first step adding an event for error faced by the users in cloud.
Data is directly pulled from the kafka topic basically skipping the intake client. So the end store is the same as the dev pipeline.
Steps to Verify