Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gray out unselected rows in table #3420

Merged
merged 6 commits into from
Nov 9, 2023
Merged

Gray out unselected rows in table #3420

merged 6 commits into from
Nov 9, 2023

Conversation

djbarnwal
Copy link
Member

In TDD gray out rows which are not included or excluded.

This PR also moves the regular-table styles inside the repo so that they can be managed easily.

@djbarnwal djbarnwal requested a review from ericpgreen2 November 8, 2023 20:34
@ericpgreen2
Copy link
Contributor

I like the direction, but I think the gray is too light. See the "2.53" and "2.3" scores for color contrast:
image
image

The numbers are close to invisible under the "low contrast" emulation:
image

Any way we can achieve the same "disabled" effect, but get the color contrast score a bit higher?

Copy link
Contributor

@ericpgreen2 ericpgreen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside of the contrast issue, code looks good, so I'll approve for you to merge at your discretion.

@djbarnwal
Copy link
Member Author

Any way we can achieve the same "disabled" effect, but get the color contrast score a bit higher?

I switched to using ui-copy-disabled-faint class which we use throughout the codebase. Still seeing that the contrast score is low. Since this is an issue for the whole application, will be good to address it separately.

@djbarnwal djbarnwal merged commit 433edd6 into main Nov 9, 2023
2 checks passed
@djbarnwal djbarnwal deleted the fix/gray-unselected branch November 9, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants