Add dialog to create a Scheduled Report #3243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djbarnwal
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Looks good. Have left some comments on using existing methods and libraries for handling time.
Also there is bug in the charts container on scrolling.
Approving so that you can merge after resolving the bug. I would leave it to you on how and when you want to address the other points.
web-common/src/features/dashboards/dimension-table/ExportDimensionTableDataButton.svelte
Outdated
Show resolved
Hide resolved
web-common/src/features/dashboards/scheduled-reports/time-utils.ts
Outdated
Show resolved
Hide resolved
web-common/src/features/dashboards/scheduled-reports/time-utils.ts
Outdated
Show resolved
Hide resolved
web-common/src/features/dashboards/time-series/MetricsTimeSeriesCharts.svelte
Outdated
Show resolved
Hide resolved
web-common/src/features/dashboards/scheduled-reports/time-utils.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a dialog to create a Scheduled Report.
Follow-on work: