Skip to content

Commit

Permalink
Fix lint+tests
Browse files Browse the repository at this point in the history
  • Loading branch information
AdityaHegde committed Jan 29, 2025
1 parent 6eb63af commit e6a6249
Show file tree
Hide file tree
Showing 6 changed files with 9 additions and 12 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
type MetricsViewSpecDimensionV2,
type V1Expression,
type V1MetricsViewAggregationMeasure,
type V1MetricsViewSpec,
type V1TimeRange,
} from "@rilldata/web-common/runtime-client";
import { runtime } from "@rilldata/web-common/runtime-client/runtime-store";
Expand All @@ -36,7 +35,6 @@
export let whereFilter: V1Expression;
export let metricsViewName: string;
export let dimensionThresholdFilters: DimensionThresholdFilter[];
export let metricsView: V1MetricsViewSpec;
export let visibleMeasureNames: string[];
export let timeControlsReady: boolean;
export let dimension: MetricsViewSpecDimensionV2;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
MetricsViewSpecDimensionV2,
V1Expression,
V1MetricsViewAggregationMeasure,
V1MetricsViewSpec,
V1TimeRange,
} from "@rilldata/web-common/runtime-client";
import {
Expand Down Expand Up @@ -59,7 +58,6 @@
export let dimensionThresholdFilters: DimensionThresholdFilter[];
export let activeMeasureName: string;
export let metricsViewName: string;
export let metricsView: V1MetricsViewSpec;
export let sortType: SortType;
export let tableWidth: number;
export let sortedAscending: boolean;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
import { getStateManagers } from "@rilldata/web-common/features/dashboards/state-managers/state-managers";
import type {
V1Expression,
V1MetricsViewSpec,
V1TimeRange,
} from "@rilldata/web-common/runtime-client";
import { runtime } from "@rilldata/web-common/runtime-client/runtime-store";
Expand All @@ -22,7 +21,6 @@
export let comparisonTimeRange: V1TimeRange | undefined;
export let timeControlsReady: boolean;
export let activeMeasureName: string;
export let metricsView: V1MetricsViewSpec;
const StateManagers = getStateManagers();
const {
Expand Down Expand Up @@ -108,7 +106,6 @@
isSummableMeasure={$isSummableMeasure}
{parentElement}
{suppressTooltip}
{metricsView}
{timeControlsReady}
selectedValues={$selectedDimensionValues(dimension.name)}
isBeingCompared={$isBeingComparedReadable(dimension.name)}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ describe("measures selectors", () => {
timeGrain: V1TimeGrain.TIME_GRAIN_DAY,
expected: {
measures: ["mes", "mes_time_no_grain"],
nonWindowMeasures: ["mes", "mes_time_no_grain"],
dimensions: [
{
name: "time",
Expand All @@ -34,6 +35,7 @@ describe("measures selectors", () => {
timeGrain: V1TimeGrain.TIME_GRAIN_DAY,
expected: {
measures: ["mes", "mes_time_no_grain", "mes_time_day_grain"],
nonWindowMeasures: ["mes", "mes_time_no_grain", "mes_time_day_grain"],
dimensions: [
{
name: "time",
Expand All @@ -53,6 +55,11 @@ describe("measures selectors", () => {
timeGrain: V1TimeGrain.TIME_GRAIN_WEEK,
expected: {
measures: ["mes", "mes_time_no_grain", "mes_time_week_grain"],
nonWindowMeasures: [
"mes",
"mes_time_no_grain",
"mes_time_week_grain",
],
dimensions: [
{
name: "time",
Expand All @@ -72,6 +79,7 @@ describe("measures selectors", () => {
timeGrain: V1TimeGrain.TIME_GRAIN_MONTH,
expected: {
measures: ["mes", "mes_time_no_grain"],
nonWindowMeasures: ["mes", "mes_time_no_grain"],
dimensions: [
{
name: "time",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ export function createTimeSeriesDataStore(
: writable({
isFetching: false,
isError: false,
data: {},
data: { data: [] },
error: undefined,
});

Expand Down
4 changes: 0 additions & 4 deletions web-common/src/features/dashboards/workspace/Dashboard.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,6 @@
}
: undefined;
$: metricsView = $explore.data?.metricsView ?? {};
let metricsWidth = DEFAULT_TIMESERIES_WIDTH;
let resizing = false;
</script>
Expand Down Expand Up @@ -187,7 +185,6 @@
{comparisonTimeRange}
activeMeasureName={$activeMeasureName}
{timeControlsReady}
{metricsView}
visibleMeasureNames={$visibleMeasures.map(
({ name }) => name ?? "",
)}
Expand All @@ -201,7 +198,6 @@
{dimensionThresholdFilters}
{timeRange}
{comparisonTimeRange}
{metricsView}
{timeControlsReady}
/>
{/if}
Expand Down

0 comments on commit e6a6249

Please sign in to comment.