Fix comparison timezone check

rilldata · Feb 3, 2025 · b452da6 · b452da6
1 parent 70122ad
commit b452da6
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/runtime/queries/metricsview_aggregation.go b/runtime/queries/metricsview_aggregation.go
@@ -332,7 +332,10 @@ func (q *MetricsViewAggregation) rewriteToMetricsViewQuery(export bool) (*metric
 		res.IsoDuration = q.ComparisonTimeRange.IsoDuration
 		res.IsoOffset = q.ComparisonTimeRange.IsoOffset
 		res.RoundToGrain = metricsview.TimeGrainFromProto(q.ComparisonTimeRange.RoundToGrain)
-		if q.ComparisonTimeRange.TimeZone != "" && qry.TimeZone == "qry.TimeZone" {
+		if q.ComparisonTimeRange.TimeZone != "" {
+			if qry.TimeZone != "" && qry.TimeZone != q.ComparisonTimeRange.TimeZone {
+				return nil, fmt.Errorf("comparison_time_range has a different time zone than ")
+			}
 			qry.TimeZone = q.ComparisonTimeRange.TimeZone
 		}
 		qry.ComparisonTimeRange = res