release snapshot on all error paths in AcquireReadConnection

rilldata · Feb 4, 2025 · 74137aa · 74137aa
1 parent af9a570
commit 74137aa
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/runtime/pkg/rduckdb/db.go b/runtime/pkg/rduckdb/db.go
@@ -302,11 +302,13 @@ func (d *db) AcquireReadConnection(ctx context.Context) (*sqlx.Conn, func() erro
 
 	conn, err := d.dbHandle.Connx(ctx)
 	if err != nil {
+		d.catalog.releaseSnapshot(snapshot)
 		return nil, nil, err
 	}
 
 	err = d.prepareSnapshot(ctx, conn, snapshot)
 	if err != nil {
+		d.catalog.releaseSnapshot(snapshot)
 		_ = conn.Close()
 		return nil, nil, err
 	}