Skip to content

Commit

Permalink
Disable EmbedCatalog on cloud (#3369)
Browse files Browse the repository at this point in the history
  • Loading branch information
k-anshul authored Nov 6, 2023
1 parent 9f55985 commit 6952d1a
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions admin/deployments.go
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ func (s *Service) createDeployment(ctx context.Context, opts *createDeploymentOp
olapConfig["cpu"] = strconv.Itoa(alloc.CPU)
olapConfig["memory_limit_gb"] = strconv.Itoa(alloc.MemoryGB)
olapConfig["storage_limit_bytes"] = strconv.FormatInt(alloc.StorageBytes, 10)
embedCatalog = true
embedCatalog = false
case "duckdb-ext-storage": // duckdb driver having capability to store table as view
if opts.ProdOLAPDSN != "" {
return nil, fmt.Errorf("passing a DSN is not allowed for driver 'duckdb-ext-storage'")
Expand All @@ -79,7 +79,7 @@ func (s *Service) createDeployment(ctx context.Context, opts *createDeploymentOp
olapConfig["memory_limit_gb"] = strconv.Itoa(alloc.MemoryGB)
olapConfig["storage_limit_bytes"] = strconv.FormatInt(alloc.StorageBytes, 10)
olapConfig["external_table_storage"] = strconv.FormatBool(true)
embedCatalog = true
embedCatalog = false
default:
olapConfig["dsn"] = opts.ProdOLAPDSN
embedCatalog = false
Expand Down

0 comments on commit 6952d1a

Please sign in to comment.