Skip to content

Commit

Permalink
Validation for deprecated name: field in rill.yaml (#6566)
Browse files Browse the repository at this point in the history
  • Loading branch information
begelundmuller authored Feb 4, 2025
1 parent 2145d9d commit 1d25ac0
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions runtime/compilers/rillv1/parse_rillyaml.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ type rillYAML struct {
DisplayName string `yaml:"display_name"`
// Title of the project
Title string `yaml:"title"` // Deprecated: use display_name
// Title of the project
Name string `yaml:"name"` // Deprecated: use display_name
// Description of the project
Description string `yaml:"description"`
// The project's default OLAP connector to use (can be overridden in the individual resources)
Expand Down Expand Up @@ -166,6 +168,9 @@ func (p *Parser) parseRillYAML(ctx context.Context, path string) error {
if tmp.Title != "" && tmp.DisplayName == "" {
tmp.DisplayName = tmp.Title
}
if tmp.Name != "" && tmp.DisplayName == "" {
tmp.DisplayName = tmp.Name
}

// Parse environment variables from the "env:" (current) and "vars:" (deprecated) keys.
vars := make(map[string]string)
Expand Down

0 comments on commit 1d25ac0

Please sign in to comment.