Skip to content

Commit

Permalink
fix proto lint
Browse files Browse the repository at this point in the history
  • Loading branch information
pjain1 committed Sep 25, 2024
1 parent 147eeda commit 0be46f1
Show file tree
Hide file tree
Showing 7 changed files with 79 additions and 79 deletions.
6 changes: 3 additions & 3 deletions admin/server/reports.go
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ func (s *Server) GetReportMeta(ctx context.Context, req *adminv1.GetReportMetaRe
}
}

externalUsersUrls := make(map[string]*adminv1.GetReportMetaResponseUrls, len(externalEmails))
externalUsersUrls := make(map[string]*adminv1.GetReportMetaResponse_Urls, len(externalEmails))
if len(externalEmails) > 0 {
// issue magic tokens for external emails
var ownerID *string
Expand All @@ -87,7 +87,7 @@ func (s *Server) GetReportMeta(ctx context.Context, req *adminv1.GetReportMetaRe
}

for email, token := range emailTokens {
externalUsersUrls[email] = &adminv1.GetReportMetaResponseUrls{
externalUsersUrls[email] = &adminv1.GetReportMetaResponse_Urls{
OpenUrl: s.admin.URLs.WithCustomDomain(org.CustomDomain).ReportOpenExternal(org.Name, proj.Name, req.Report, token, req.ExecutionTime.AsTime()),
ExportUrl: s.admin.URLs.WithCustomDomain(org.CustomDomain).ReportExportExternal(org.Name, proj.Name, req.Report, token),
}
Expand All @@ -101,7 +101,7 @@ func (s *Server) GetReportMeta(ctx context.Context, req *adminv1.GetReportMetaRe
}

return &adminv1.GetReportMetaResponse{
InternalUsersUrls: &adminv1.GetReportMetaResponseUrls{
InternalUsersUrls: &adminv1.GetReportMetaResponse_Urls{
OpenUrl: s.admin.URLs.WithCustomDomain(org.CustomDomain).ReportOpen(org.Name, proj.Name, req.Report, req.ExecutionTime.AsTime()),
ExportUrl: s.admin.URLs.WithCustomDomain(org.CustomDomain).ReportExport(org.Name, proj.Name, req.Report),
EditUrl: s.admin.URLs.WithCustomDomain(org.CustomDomain).ReportEdit(org.Name, proj.Name, req.Report),
Expand Down
6 changes: 3 additions & 3 deletions proto/gen/rill/admin/v1/admin.swagger.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3442,7 +3442,7 @@ paths:
tags:
- AdminService
definitions:
GetReportMetaResponseurls:
GetReportMetaResponseUrls:
type: object
properties:
openUrl:
Expand Down Expand Up @@ -4083,11 +4083,11 @@ definitions:
type: object
properties:
internalUsersUrls:
$ref: '#/definitions/GetReportMetaResponseurls'
$ref: '#/definitions/GetReportMetaResponseUrls'
externalUsersUrls:
type: object
additionalProperties:
$ref: '#/definitions/GetReportMetaResponseurls'
$ref: '#/definitions/GetReportMetaResponseUrls'
v1GetUserResponse:
type: object
properties:
Expand Down
44 changes: 22 additions & 22 deletions proto/gen/rill/admin/v1/api.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

54 changes: 27 additions & 27 deletions proto/gen/rill/admin/v1/api.pb.validate.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions proto/rill/admin/v1/api.proto
Original file line number Diff line number Diff line change
Expand Up @@ -1833,13 +1833,13 @@ message GetReportMetaRequest {
}

message GetReportMetaResponse {
message urls {
message Urls {
string open_url = 1;
string export_url = 2;
string edit_url = 3;
}
urls internal_users_urls = 1;
map<string, urls> external_users_urls = 2;
Urls internal_users_urls = 1;
map<string, Urls> external_users_urls = 2;
}

message GetAlertMetaRequest {
Expand Down
6 changes: 3 additions & 3 deletions web-admin/src/client/gen/index.schemas.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1000,11 +1000,11 @@ export interface V1GetUserResponse {
}

export type V1GetReportMetaResponseExternalUsersUrls = {
[key: string]: GetReportMetaResponseurls;
[key: string]: GetReportMetaResponseUrls;
};

export interface V1GetReportMetaResponse {
internalUsersUrls?: GetReportMetaResponseurls;
internalUsersUrls?: GetReportMetaResponseUrls;
externalUsersUrls?: V1GetReportMetaResponseExternalUsersUrls;
}

Expand Down Expand Up @@ -1488,7 +1488,7 @@ export interface ListGithubUserReposResponseRepo {
defaultBranch?: string;
}

export interface GetReportMetaResponseurls {
export interface GetReportMetaResponseUrls {
openUrl?: string;
exportUrl?: string;
editUrl?: string;
Expand Down
Loading

0 comments on commit 0be46f1

Please sign in to comment.