Skip to content

Commit

Permalink
Adding support for defining filters on measures (#3624)
Browse files Browse the repository at this point in the history
* Initial commit

* Using enum for expression and adding to metricsview_aggregation

* Comparison in measure filters

* Adding to metricsview toplist

* Updated proto spec

* Add generic expression syntax

* Final proto draft

* Integrate and test where filter

* Integrate where clause everywhere

* Adding some tests for having clauses

* Add backwards compatibility for filter

* fix lint

* Adding alias support in metricsview_comparison_toplist

* Apply sum() only when having is enabled

* Fix lint

* PR comments

* Move filter helpers to pkg/expressionpb

* refactor filter builder to not use map

* Backwards compatibility for older sort types

* PR comments

* Testing on druid and fixes

* Using outer query

* Removing unused testdata
  • Loading branch information
AdityaHegde authored Dec 18, 2023
1 parent edafbe6 commit 07cadb9
Show file tree
Hide file tree
Showing 47 changed files with 5,592 additions and 2,390 deletions.
399 changes: 399 additions & 0 deletions proto/gen/rill/runtime/v1/expression.pb.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

1 comment on commit 07cadb9

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.