Move to ComposableLogsSheetKit

[yermukhanbet]

• Changed name to ComposableLogsSheetKit
• Moved LogsSheet as 3rd party library

LogsSheetKit:
https://github.com/riiid/LogsSheetKit

[korJAEYOUNGYUN]

❓ I think it is better to be able to customize log message(not just action) for the open source purpose.

[yermukhanbet]

How about adding one more function?

    public func log(isDebug: Bool, with message: String) -> Self {
    .init { state, action, environment in
      if isDebug {
        state.logs.append(.init(message: message))
      }
      return self.run(&state, action, environment)
    }
  }

[yermukhanbet]

a786f19 에 추가 했어요!

[korJAEYOUNGYUN]

in that case we cannot use action.
what i mean is like this

public func log(
  isDebug: Bool, 
  withMessage message: @escaping (Action) -> String)
) -> Self {
  if isDebug {
    state.logs.append(.init(message: message(action)))
  }
  return self.run(&state, action, environment)
}

then, the user can customize log message using action

[yermukhanbet]

Wow! I like that way better! 🔥
8cbaf39 에 추가 했어요!

[korJAEYOUNGYUN]

❓ Is it okay to have logs without maximum capacity?

[yermukhanbet]

You mean limit size of the logs array?

[korJAEYOUNGYUN]

yes! What's your thought about it?

[yermukhanbet]

That sounds good for me in case of for instance big amount of logs, which then will have to be shown all at once in the LogsSheet. If the amount is too big, it is very unlikely that user will scroll down till the end.

However, I think for the debug reasons, sometimes we want to know the whole path of actions, which might need to see the very first actions as well as very last ones.

[korJAEYOUNGYUN]

wow, I totally agree with you that someone may want the start of the log.

[tisohjung]

Awesome 🎉

[korJAEYOUNGYUN]

고생하셨습니다 👍

[korJAEYOUNGYUN]