Add support for int on PropertyCollection #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also added automatic return type and fixed my mistakes on the first commit because it was only returning the So that it no longer requires |
IchimakiKasura
added a commit
to IchimakiKasura/Launcher-DL-3
that referenced
this pull request
Mar 2, 2023
So the IniParser repo has some annoying weird thing like It wont return the actual type I actually modified it and also added support by Int search other than the string I already did a PR check below: rickyah/ini-parser#248
Added TryParse on IniDataParser
causes weird issue when reading single decimals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just found this cool ini-parser but I've encountered little problem while working on my project.
On the single Section I have many properties which by the way has long names.
So my PR would be adding an INT or Numbers support to look like this
Which is also can be used when using a Loop when having too many properties on a section.
I hope my code changes helps!