This repository has been archived by the owner on Jul 7, 2022. It is now read-only.
Allows entering an email (str) directly instead of having to send to Contact objects #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Contact objects. Fix error in new_contact: nickname -> name.
|
+1 |
rbrcsk
pushed a commit
that referenced
this pull request
Dec 7, 2014
Allows entering an email (str) directly instead of having to send to Contact objects
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my Django application I want to send pushes to the admins, specifically to their email addresses as registered in the database.
This pull request allows for entering email strings directly just like devices or contacts.
I also refactored a little to make the device/email bit more DRY.
Also in new_contact there was a reference to a nonexistent variable "nickname", so I replaced that with "name" which I assume is what was intended.