Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX(formatter) creation-time field format fix #32

Merged
merged 2 commits into from
Feb 16, 2023

Conversation

pematous
Copy link

No description provided.

@pematous pematous changed the title Pm creation time field format fix FIX(formatter) creation-time field format fix Feb 15, 2023
@pematous pematous requested a review from jiridanek February 15, 2023 14:58
Copy link
Member

@jiridanek jiridanek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This implements the changes from https://github.com/amqp/rhea/releases/tag/2.0.0

so I think you should also address the absolute_expiry_time

lib/formatter.js Show resolved Hide resolved
lib/formatter.js Show resolved Hide resolved
@jiridanek
Copy link
Member

absolute_expiry_time is not really within scope, so I understand not fixing it here and leaving it for later...

@jiridanek jiridanek merged commit a2b5bb6 into master Feb 16, 2023
@jiridanek jiridanek deleted the pm_creation_time_field_format_fix branch February 16, 2023 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants