Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heal Bell/Aromatherapy/Sparkly Swirl improvements and fixes #6210

Merged

Conversation

AsparagusEduardo
Copy link
Collaborator

Description

  • Checking B_HEAL_BELL_AROMATHERAPY configs during tests.
  • Sparkly Swirl was given MOVE_EFFECT_AROMATHERAPY.
  • Removed hardcoding of Heal Bell's move ID, instead checking for the sound move flag.

Issue(s) that this PR fixes

Feature(s) this PR does NOT handle:

Doesn't handle modern game messages or ability popups.
For now, Heal Bell does "A bell chimed", while everything else does "an aroma wafted". G-Max Sweetness' message wasn't accurate before this, so there's no regression.
image

Things to note in the release changelog:

  • Removed EFFECT_SPARKLY_SWIRL in favor of MOVE_EFFECT_AROMATHEROPY.

Discord contact info

AsparagusEduardo

@AsparagusEduardo AsparagusEduardo changed the title Given Sparkly Swirl MOVE_EFFECT_AROMATHERAPY Heal Bell/Aromatherapy/Sparkly Swirl improvements and fixes Feb 7, 2025
@Pawkkie Pawkkie added category: move effect Pertains to move effects bug Bug labels Feb 7, 2025
@AlexOn1ine AlexOn1ine merged commit a2ad5d2 into rh-hideout:upcoming Feb 9, 2025
1 check passed
@AsparagusEduardo AsparagusEduardo deleted the _RHH/pr/upcoming/sparklySwirl branch February 9, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug category: move effect Pertains to move effects
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants