Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test support for 5 battle configs #5914

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

AsparagusEduardo
Copy link
Collaborator

Description

  • B_CRIT_CHANCE
  • B_CRIT_MULTIPLIER
  • B_PARALYSIS_SPEED
  • B_CONFUSION_SELF_DMG_CHANCE
  • B_MULTI_HIT_CHANCE

Discord contact info

AsparagusEduardo

@AlexOn1ine AlexOn1ine added the category: battle-tests Related to the automated test environment label Dec 31, 2024
@Bassoonian
Copy link
Collaborator

Marking this as draft until the requested changes are applied

@Bassoonian Bassoonian marked this pull request as draft February 7, 2025 22:46
@AsparagusEduardo AsparagusEduardo marked this pull request as ready for review February 8, 2025 22:29
@AsparagusEduardo
Copy link
Collaborator Author

My god, this was a journey and a half to get all the Gen 1 configs properly tested.
Found that Focus Energy wasn't properly changing for Gen 2, so added a config to that, and that some Gen 1 handling was not proper.

Ready for re-review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: battle-tests Related to the automated test environment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants