forked from DizzyEggg/pokeemerald
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added test support for 5 battle configs #5914
Open
AsparagusEduardo
wants to merge
19
commits into
rh-hideout:master
Choose a base branch
from
AsparagusEduardo:_RHH/pr/master/genConfigs2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Added test support for 5 battle configs #5914
AsparagusEduardo
wants to merge
19
commits into
rh-hideout:master
from
AsparagusEduardo:_RHH/pr/master/genConfigs2
+562
−409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bassoonian
reviewed
Dec 31, 2024
Marking this as draft until the requested changes are applied |
Added config for setting Focus Energy's crit ratio
My god, this was a journey and a half to get all the Gen 1 configs properly tested. Ready for re-review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
B_CRIT_CHANCE
B_CRIT_MULTIPLIER
B_PARALYSIS_SPEED
B_CONFUSION_SELF_DMG_CHANCE
B_MULTI_HIT_CHANCE
Discord contact info
AsparagusEduardo