Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Vsphere Functionality to deployment #489
base: main
Are you sure you want to change the base?
Adding Vsphere Functionality to deployment #489
Changes from 13 commits
74a7c22
1166b3a
c7287b7
810e8a4
4c124b8
1fd045c
43b69e3
d010656
abafd2d
581a949
eaa7c6c
4af1708
c31bb37
fee4bed
3c58dbc
67b528e
ff681bf
e649df3
2d2ce40
b85a4fb
b99252a
2f6d356
b51278b
5d46bcb
48cb055
53b2743
51fcc57
8a1a9ba
b2d231e
6d57872
1aada8a
27cc55b
ece7a5d
774a16b
17f2fbf
e032198
d9fced4
7373aa3
cf7ce29
5b692ad
aab553f
9918bfa
93c2978
d025d69
989b12c
e54bf42
301f177
dae5a8c
f7c3b79
b80e3fd
1203f33
aba9678
6f95e1b
1e0cde6
9db552a
51e462b
b71e01e
e286aad
106f6e9
b4551f5
60ffe44
18e6042
5a8daa4
836321b
5a92835
dc609c6
9d734f2
7846cf3
7430736
6e4572f
a5c6b48
5e784fe
101e7d9
80a43e9
8e9d65c
8b60433
e7d801d
2c6e595
ce9fcce
3b086e8
ef14135
abba130
5425f28
1e89864
ec418ed
4f31697
3276326
1d87f66
377f11a
686b025
04b7d2c
f5f7b7d
33dafd4
a0655cd
1262656
3de8eea
f847c43
49c90dd
938b442
43c39a5
5ca3528
ec174a5
f807806
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the common.sh file there is a check_resources which do exactly this part. An example:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same than before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to make it clear, the idea of the contrib framework is to have an interface with 2 functions:
So, said that, in this part an example of verify could be:
Verify.sh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need argocd? Maybe I'm wrong or missing something but I think we don't need argocd to deploy it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment regarding the question about why need argocd ;)