Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/33 read daily agenda #37

Merged
merged 5 commits into from
Jul 2, 2024
Merged

Feat/33 read daily agenda #37

merged 5 commits into from
Jul 2, 2024

Conversation

OneK-2
Copy link
Collaborator

@OneK-2 OneK-2 commented Jul 1, 2024

✨ 요약

업데이트 에러처리 수정
페이징 정렬 조회 추가



😎 해결한 이슈



Copy link

github-actions bot commented Jul 1, 2024

Unit Test Results

37 tests   37 ✔️  7s ⏱️
  8 suites    0 💤
  8 files      0

Results for commit cf56ce8.

♻️ This comment has been updated with latest results.

@minwoo1999
Copy link
Member

테스트 커버리지 측정

File Coverage [87.62%] 🍏
DailyAgendaServiceImpl.java 87.62% 🍏
Total Project Coverage 72.26% 🍏

@OneK-2 OneK-2 requested a review from minwoo1999 July 1, 2024 13:24
@OneK-2 OneK-2 self-assigned this Jul 1, 2024
@OneK-2 OneK-2 added Feat 기능 추가 test 테스트코드 추가 labels Jul 1, 2024
@OneK-2 OneK-2 added this to the v2.0.0 milestone Jul 1, 2024
@minwoo1999
Copy link
Member

테스트 커버리지 측정

File Coverage [86.55%] 🍏
DailyAgendaServiceImpl.java 86.55% 🍏
Total Project Coverage 72.15% 🍏

Copy link
Member

@minwoo1999 minwoo1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -53,6 +53,7 @@ public ReadDailyAgendaResponseDto readDailyAgenda(int year, int month, int day,
}

List<ReadDetailDailyAgendaResponseDto> result = agendaList.stream()
.sorted((a1, a2) -> Long.compare(a2.getPagingId(), a1.getPagingId()))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

람다 스트림 sorted로 정렬하셨군요 !! 좋습니다 !! 고생하셨습니다~~

@klmhyeonwoo
Copy link
Member

"빨리 배포해줘"

@OneK-2 OneK-2 merged commit 2251eb5 into develop Jul 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feat 기능 추가 test 테스트코드 추가
Projects
Status: 완료된 이슈 (Done)
Development

Successfully merging this pull request may close these issues.

[FEAT] 아젠다 조회시 pagingId 기준 정렬하여 반환
3 participants