Feat/9 monthly agenda #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minwoo1999
approved these changes
May 23, 2024
| LocalDateTime start = YearMonth.of(readMonthlyAgendaRequestDto.getYear(), readMonthlyAgendaRequestDto.getMonth()).atDay(1).atStartOfDay(); | ||
| LocalDateTime end = YearMonth.of(readMonthlyAgendaRequestDto.getYear(), readMonthlyAgendaRequestDto.getMonth()).atEndOfMonth().atTime(23, 59, 59); | ||
|
|
||
| Optional<MonthlyAgenda> monthlyAgendaOptional = monthlyAgendaRepository.findByMemberIdAndCreatedAtBetween(currentUserId, start, end); |
There was a problem hiding this comment.
해당 부분을 orElseThrow로 처리해서 if else 문 안쓰고처리하는방법은 어떨까요!?
There was a problem hiding this comment.
아아 빈배열 반환을 위해 저렇게 하신거군요 ! 이해했습니다
| @@ -63,6 +63,7 @@ public SecurityFilterChain filterChain(HttpSecurity http) throws Exception { | |||
| .authorizeHttpRequests((authorizeRequests) -> | |||
| authorizeRequests | |||
| .requestMatchers("/api/v1/members/signup", "/api/v1/members/login/**","/api/v1/members/renew-access-token","/api/v1/members/logout").permitAll() | |||
| .requestMatchers("/api/v1/monthlyAgenda/**").permitAll() | |||
There was a problem hiding this comment.
저 경로 밑에 있는 경로 전부 오픈시키면 로그인 하지않은 유저들도 해당 API에 데이터에 접근할 수 있을 것 같아요! Member 등급 이상인 권한을 가진 유저들만 API해당 접근할 수있도록 수정해주시면 좋을 것같습니다!
There was a problem hiding this comment.
아 테스트용 설정했는데, 깜빡했습니다.!
minwoo1999
approved these changes
May 23, 2024
| summary = "이번달 아젠다 삭제", | ||
| description = "이번달 아젠다를 삭제하는 API, 현재는 필요하지 않음." | ||
| ) | ||
| @DeleteMapping("/delete") |
There was a problem hiding this comment.
restful 규칙: 행위를 포함하지 않는다.
이거 혹시 / 나 행위가 포함되지않도록 하는건 어떨까요?
| summary = "이번달 아젠다 수정", | ||
| description = "사용자가 설정한 이번달 아젠다를 수정하는 API" | ||
| ) | ||
| @PutMapping("/update") |
There was a problem hiding this comment.
restful 규칙: 행위를 포함하지 않는다.
이거 혹시 / 나 행위가 포함되지않도록 하는건 어떨까요?
| summary = "이번달 아젠다 등록", | ||
| description = "사용자가 입력한 이번달 아젠다를 저장하는 API" | ||
| ) | ||
| @PostMapping("/create") |
There was a problem hiding this comment.
restful 규칙: 행위를 포함하지 않는다.
이거 혹시 / 나 행위가 포함되지않도록 하는건 어떨까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ 요약
😎 해결한 이슈