Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(builtins): fix read builtin ignoring tab chars #371

Merged
merged 1 commit into from
Feb 1, 2025
Merged

Conversation

reubeno
Copy link
Owner

@reubeno reubeno commented Feb 1, 2025

Some ASCII whitespace characters (e.g., \t) are also considered control characters. Don't ignore all of them in read.

@reubeno reubeno enabled auto-merge (squash) February 1, 2025 07:15
@reubeno reubeno requested a review from Copilot February 1, 2025 07:19

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@reubeno reubeno merged commit d8a57de into main Feb 1, 2025
17 checks passed
@reubeno reubeno deleted the read-fix branch February 1, 2025 07:26
Copy link

github-actions bot commented Feb 1, 2025

Test Results

    2 files      9 suites   1m 32s ⏱️
  668 tests   668 ✅ 0 💤 0 ❌
1 322 runs  1 322 ✅ 0 💤 0 ❌

Results for commit 2f48db0.

Copy link

github-actions bot commented Feb 1, 2025

Performance Benchmark Report

Benchmark name Baseline (μs) Test/PR (μs) Delta (μs) Delta %
clone_shell_object 18.15 μs 18.13 μs -0.02 μs ⚪ Unchanged
eval_arithmetic 0.17 μs 0.18 μs 0.00 μs ⚪ Unchanged
expand_one_string 1.62 μs 1.58 μs -0.05 μs ⚪ Unchanged
for_loop 21.97 μs 21.74 μs -0.23 μs ⚪ Unchanged
function_call 2.48 μs 2.36 μs -0.12 μs ⚪ Unchanged
instantiate_shell 56.84 μs 57.23 μs 0.39 μs ⚪ Unchanged
instantiate_shell_with_init_scripts 22409.84 μs 21592.24 μs -817.60 μs 🟢 -3.65%
parse_bash_completion 1660.94 μs 1666.07 μs 5.12 μs ⚪ Unchanged
parse_sample_script 1.76 μs 1.82 μs 0.07 μs 🟠 +3.93%
run_echo_builtin_command 15.63 μs 15.13 μs -0.50 μs ⚪ Unchanged
run_one_external_command 2441.33 μs 2092.89 μs -348.44 μs 🟢 -14.27%
tokenize_sample_script 2.97 μs 2.85 μs -0.11 μs 🟢 -3.87%

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
Overall Coverage 🟢 75.67% 🟢 75.67% ⚪ 0%

Minimum allowed coverage is 70%, this run produced 75.67%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant