Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello lovely humans,
jsdom just published its new version 11.0.0.
This version is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of jsdom.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project ✨
You rock!
🌴
The new version differs by 244 commits .
0f4128d
Version 11.0.0
be65539
Fix event handler property generation to properly rely on runScripts
38c430f
Factor out runScripts option tests
ecf7449
Do not submit disconnected form elements
5f3cbd6
Properly implement event handler properties/attributes
3eb19e7
Remove a few more now-redundant toString()s
b1b7f23
Refactor XHR's send() implementation
7d950c4
Delete keygen from default stylesheet
5151546
Remove other unsupported CSS features from the default stylesheet
dfc9430
Delete webkit prefixes and other internal selectors in default CSS
56fbd0d
Support ArrayBufferViews in xhr.send()
ce13678
Disable yet another flaky-on-CI XHR test
dabf1a4
Remove createCDATASection from benchmarks
2d257ef
Update benchmark runner to support the new API
1833f78
Use Set instead of Array for HTMLCollection keys
There are 244 commits in total. See the full diff.