-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added to Resend.php Facade: Contact, Audience and Batch methods #70
Open
cheddZy
wants to merge
5
commits into
resend:main
Choose a base branch
from
cheddZy:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9f31f8e
Added to Resend.php Facade: Contact, Audience and Batch methods
cheddZy ef398c9
Replaced Facade methods for PHPDoc
cheddZy bad30eb
Replaced existing Facade methods for PHPDoc
cheddZy 429f0b3
Adding the previously existing methods back (woops!)
cheddZy 35969b7
Added tests for new methods, updated Resend facade with PHPDoc
cheddZy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -4,26 +4,31 @@ | |||||||
|
||||||||
use Illuminate\Support\Facades\Facade; | ||||||||
use Resend\Service\ApiKey; | ||||||||
use Resend\Service\Audience; | ||||||||
use Resend\Service\Batch; | ||||||||
use Resend\Service\Contact; | ||||||||
use Resend\Service\Domain; | ||||||||
use Resend\Service\Email; | ||||||||
|
||||||||
class Resend extends Facade | ||||||||
{ | ||||||||
public static function apiKeys(): ApiKey | ||||||||
{ | ||||||||
return static::getFacadeRoot()->apiKeys; | ||||||||
} | ||||||||
/** | ||||||||
* Provides Resend integration for Laravel and Symfony Mailer. | ||||||||
* | ||||||||
* @method static Contact contacts() Manage Resend contacts. | ||||||||
* @method static Audience audiences() Manage Resend audiences through the Resend Email API. | ||||||||
* @method static Batch batch() Create and send Resend Batches. | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
* @method static ApiKey apiKeys() Manage Resend API keys. | ||||||||
* @method static Domain domains() Manage Resend domains. | ||||||||
* @method static Email emails() Manage Resend Emails. | ||||||||
* | ||||||||
* @package resend-laravel | ||||||||
* @see <a href="https://resend.com/docs/introduction">Resend Docs</a> | ||||||||
* @see <a href="https://resend.com/docs/api-reference/introduction">API Reference</a> | ||||||||
*/ | ||||||||
|
||||||||
public static function domains(): Domain | ||||||||
{ | ||||||||
return static::getFacadeRoot()->domains; | ||||||||
} | ||||||||
|
||||||||
public static function emails(): Email | ||||||||
{ | ||||||||
return static::getFacadeRoot()->emails; | ||||||||
} | ||||||||
|
||||||||
class Resend extends Facade | ||||||||
{ | ||||||||
/** | ||||||||
* Get the registered name of the component. | ||||||||
*/ | ||||||||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
|
@@ -3,6 +3,9 @@ | |||||||
use Resend\Client; | ||||||||
use Resend\Laravel\Facades\Resend; | ||||||||
use Resend\Service\ApiKey; | ||||||||
use Resend\Service\Audience; | ||||||||
use Resend\Service\Batch; | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
use Resend\Service\Contact; | ||||||||
use Resend\Service\Domain; | ||||||||
use Resend\Service\Email; | ||||||||
|
||||||||
|
@@ -25,5 +28,8 @@ | |||||||
|
||||||||
expect(Resend::apiKeys())->toBeInstanceOf(ApiKey::class) | ||||||||
->and(Resend::domains())->toBeInstanceOf(Domain::class) | ||||||||
->and(Resend::emails())->toBeInstanceOf(Email::class); | ||||||||
->and(Resend::emails())->toBeInstanceOf(Email::class) | ||||||||
->and(Resend::contacts())->toBeInstanceOf(Contact::class) | ||||||||
->and(Resend::batch())->toBeInstanceOf(Batch::class) | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
->and(Resend::audiences())->toBeInstanceOf(Audience::class); | ||||||||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.